From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B182420EC8E for ; Fri, 26 Apr 2024 09:17:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BBCE337F7C; Fri, 26 Apr 2024 09:17:27 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 26 Apr 2024 09:17:24 +0200 Message-Id: <20240426071724.1126646-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: resource mappings: fix editing of mapping for non first node X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" when editing the pci mapping, we set the nodename of the pciselector to the selected node. At the same time we disable and hide the node selector, but it still changes it's value to the 'first' node (alphabetically sorted) and that triggers a change event. To prevent that we accidentally set the node of the pciselector too, we need to check here if the field is disabled. Signed-off-by: Dominik Csapak --- www/manager6/window/PCIMapEdit.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/window/PCIMapEdit.js b/www/manager6/window/PCIMapEdit.js index d43f04eb..faf58255 100644 --- a/www/manager6/window/PCIMapEdit.js +++ b/www/manager6/window/PCIMapEdit.js @@ -126,8 +126,10 @@ Ext.define('PVE.window.PCIMapEditWindow', { this.lookup('pciselector').setMdev(value); }, - nodeChange: function(_field, value) { - this.lookup('pciselector').setNodename(value); + nodeChange: function(field, value) { + if (!field.isDisabled()) { + this.lookup('pciselector').setNodename(value); + } }, pciChange: function(_field, value) { -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel