From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D580B20EC88 for ; Thu, 25 Apr 2024 10:41:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E90E1D59E; Thu, 25 Apr 2024 10:41:35 +0200 (CEST) From: Alexander Zeidler To: pve-devel@lists.proxmox.com Date: Thu, 25 Apr 2024 10:40:21 +0200 Message-Id: <20240425084022.73416-1-a.zeidler@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer] install module: getters: correctly use plural in error messages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Alexander Zeidler --- Proxmox/Install.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 6ad9d17..c0f8955 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -255,7 +255,7 @@ sub get_zfs_raid_setup { $cmd .= " @$hd[1]"; } } elsif ($filesys eq 'zfs (RAID1)') { - die "zfs (RAID1) needs at least 2 device\n" if $diskcount < 2; + die "zfs (RAID1) needs at least 2 devices\n" if $diskcount < 2; $cmd .= ' mirror '; my $hd = @$devlist[0]; my $expected_size = @$hd[2]; # all disks need approximately same size @@ -265,7 +265,7 @@ sub get_zfs_raid_setup { $cmd .= " @$hd[1]"; } } elsif ($filesys eq 'zfs (RAID10)') { - die "zfs (RAID10) needs at least 4 device\n" if $diskcount < 4; + die "zfs (RAID10) needs at least 4 devices\n" if $diskcount < 4; die "zfs (RAID10) needs an even number of devices\n" if $diskcount & 1; for (my $i = 0; $i < $diskcount; $i+=2) { @@ -329,10 +329,10 @@ sub get_btrfs_raid_setup { if ($filesys eq 'btrfs (RAID0)') { $mode = 'raid0'; } elsif ($filesys eq 'btrfs (RAID1)') { - die "btrfs (RAID1) needs at least 2 device\n" if $diskcount < 2; + die "btrfs (RAID1) needs at least 2 devices\n" if $diskcount < 2; $mode = 'raid1'; } elsif ($filesys eq 'btrfs (RAID10)') { - die "btrfs (RAID10) needs at least 4 device\n" if $diskcount < 4; + die "btrfs (RAID10) needs at least 4 devices\n" if $diskcount < 4; $mode = 'raid10'; } else { die "unknown btrfs mode '$filesys'\n"; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel