From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BF88420EC88 for ; Wed, 24 Apr 2024 13:03:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 55B4C9763; Wed, 24 Apr 2024 13:04:04 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 24 Apr 2024 13:03:58 +0200 Message-Id: <20240424110358.2024238-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: fix pbs storage edit reset behavior X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" two similar things to fix here: * the 'crypt-allow-edit' field was not submitted, but it's value was only ever set with a bind, so a reset always set it to it's default 'false' value (disabling the radio buttons, even when it was not visible) * the initial value of the 'keep' variant of the radiofield was decided only from 'isCreate' (via the 'checked' cbind), but should have been decided by whether there was an encryption key or not. both are fixed by setting the values in the 'setValue' method explicitly Signed-off-by: Dominik Csapak --- www/manager6/storage/PBSEdit.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js index 70dc42f5..95bf0a50 100644 --- a/www/manager6/storage/PBSEdit.js +++ b/www/manager6/storage/PBSEdit.js @@ -220,11 +220,14 @@ Ext.define('PVE.panel.PBSEncryptionKeyTab', { // old key without FP values['crypt-key-fp'] = icon + gettext('Active'); } + values.cryptMode = 'keep'; + values['crypt-allow-edit'] = false; } else { values['crypt-key-fp'] = gettext('None'); let cryptModeNone = me.down('radiofield[inputValue=none]'); cryptModeNone.setBoxLabel(gettext('Do not encrypt backups')); - cryptModeNone.setValue(true); + values.cryptMode = 'none'; + values['crypt-allow-edit'] = true; } vm.set('keepCryptVisible', !!cryptKeyInfo); vm.set('allowEdit', !cryptKeyInfo); @@ -272,7 +275,6 @@ Ext.define('PVE.panel.PBSEncryptionKeyTab', { padding: '0 0 0 25', cbind: { hidden: '{isCreate}', - checked: '{!isCreate}', }, bind: { hidden: '{!keepCryptVisible}', -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel