From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C6AC120EC7F for ; Tue, 23 Apr 2024 17:18:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5DE8335257; Tue, 23 Apr 2024 17:18:58 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 23 Apr 2024 17:18:06 +0200 Message-Id: <20240423151806.2665929-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [answer.rs] Subject: [pve-devel] [PATCH installer] assistant: error out on set network config for dhcp X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" potentially will not happen too often in practice if the sample files always contain the right source. Still having settings in an answer file that get ignored does not seem right. tested with `validate-answer` on a file without `source` in the network section (which initially caused confusion for me) Signed-off-by: Stoiko Ivanov --- proxmox-auto-installer/src/answer.rs | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/proxmox-auto-installer/src/answer.rs b/proxmox-auto-installer/src/answer.rs index de8a360..df20db3 100644 --- a/proxmox-auto-installer/src/answer.rs +++ b/proxmox-auto-installer/src/answer.rs @@ -87,6 +87,19 @@ impl TryFrom for Network { }), }) } else { + if network.cidr.is_some() { + return Err("Field 'cidr' not supported for 'from-dhcp' config."); + } + if network.dns.is_some() { + return Err("Field 'dns' not supported for 'from-dhcp' config."); + } + if network.gateway.is_some() { + return Err("Field 'gateway' not supported for 'from-dhcp' config."); + } + if network.filter.is_some() { + return Err("Field 'filter' not supported for 'from-dhcp' config."); + } + Ok(Network { network_settings: NetworkSettings::FromDhcp, }) -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel