From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 23EDF1FF56B for ; Mon, 22 Apr 2024 10:31:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AD157B119; Mon, 22 Apr 2024 10:31:30 +0200 (CEST) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Mon, 22 Apr 2024 10:31:06 +0200 Message-Id: <20240422083116.99809-7-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240422083116.99809-1-l.wagner@proxmox.com> References: <20240422083116.99809-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v6 06/16] vzdump: apt: notification: do not include domain in 'hostname' field X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" - The man page warns about the usage of `hostname -f`, since a host may have multiple domains (or none at all) - The fallback PVE::INotify::nodename() already only returned the hostname without the domain part - Fencing notifications didn't include the domain part anyway This may result in soft-breakage for any users who have already relied on the domain being present. If there is need for it, it could include a fqdn metadata field. The hostname property used for rendering the notification template is unaffected for now. Signed-off-by: Lukas Wagner --- PVE/API2/APT.pm | 3 ++- PVE/VZDump.pm | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm index 19f0baca..c37abb0c 100644 --- a/PVE/API2/APT.pm +++ b/PVE/API2/APT.pm @@ -354,7 +354,8 @@ __PACKAGE__->register_method({ # matchers. my $metadata_fields = { type => 'package-updates', - hostname => $hostname, + # Hostname (without domain part) + hostname => PVE::INotify::nodename(), }; PVE::Notify::info( diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index df5165bd..a860540b 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -508,10 +508,9 @@ sub send_notification { "See Task History for details!\n"; }; - my $hostname = get_hostname(); - my $notification_props = { - "hostname" => $hostname, + # Hostname, might include domain part + "hostname" => get_hostname(), "error-message" => $err, "guest-table" => build_guest_table($tasklist), "logs" => $text_log_part, @@ -522,7 +521,8 @@ sub send_notification { my $fields = { type => "vzdump", - hostname => $hostname, + # Hostname (without domain part) + hostname => PVE::INotify::nodename(), }; # Add backup-job metadata field in case this is a backup job. $fields->{'job-id'} = $job_id if $job_id; -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel