From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 741431FF37F for ; Thu, 18 Apr 2024 15:47:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE2221DAE5; Thu, 18 Apr 2024 15:47:14 +0200 (CEST) From: Friedrich Weber To: pve-devel@lists.proxmox.com Date: Thu, 18 Apr 2024 15:46:35 +0200 Message-Id: <20240418134637.262082-3-f.weber@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240418134637.262082-1-f.weber@proxmox.com> References: <20240418134637.262082-1-f.weber@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm] Subject: [pve-devel] [PATCH qemu-server 2/4] api: stop: reword overrule-shutdown parameter description X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The previous wording made it sound like all "visible" tasks were aborted, which is not the case: A user with Sys.Audit but without Sys.Modify may see a task that was started by a different user, but overrule-shutdown would not abort the task. Change wording to better reflect that not all visible tasks may be aborted. Also, add a full-stop that was previously missing. Signed-off-by: Friedrich Weber --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 00cd907..2a349c8 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -3043,7 +3043,7 @@ __PACKAGE__->register_method({ default => 0, }, 'overrule-shutdown' => { - description => "Abort any active and visible 'qmshutdown' tasks before stopping", + description => "Try to abort active 'qmshutdown' tasks before stopping.", optional => 1, type => 'boolean', default => 0, -- 2.39.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel