From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5612596EAC for ; Tue, 16 Apr 2024 15:20:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 221471BB2A for ; Tue, 16 Apr 2024 15:19:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 16 Apr 2024 15:19:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8A54745115 for ; Tue, 16 Apr 2024 15:19:17 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 16 Apr 2024 15:19:03 +0200 Message-Id: <20240416131909.2867605-11-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240416131909.2867605-1-d.csapak@proxmox.com> References: <20240416131909.2867605-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 1/3] api: delete unused OVF.pm X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2024 13:20:18 -0000 the api part was never in use by anything Signed-off-by: Dominik Csapak --- PVE/API2/Qemu/Makefile | 2 +- PVE/API2/Qemu/OVF.pm | 53 ------------------------------------------ 2 files changed, 1 insertion(+), 54 deletions(-) delete mode 100644 PVE/API2/Qemu/OVF.pm diff --git a/PVE/API2/Qemu/Makefile b/PVE/API2/Qemu/Makefile index bdd4762b..5d4abda6 100644 --- a/PVE/API2/Qemu/Makefile +++ b/PVE/API2/Qemu/Makefile @@ -1,4 +1,4 @@ -SOURCES=Agent.pm CPU.pm Machine.pm OVF.pm +SOURCES=Agent.pm CPU.pm Machine.pm .PHONY: install install: diff --git a/PVE/API2/Qemu/OVF.pm b/PVE/API2/Qemu/OVF.pm deleted file mode 100644 index cc0ef2da..00000000 --- a/PVE/API2/Qemu/OVF.pm +++ /dev/null @@ -1,53 +0,0 @@ -package PVE::API2::Qemu::OVF; - -use strict; -use warnings; - -use PVE::JSONSchema qw(get_standard_option); -use PVE::QemuServer::OVF; -use PVE::RESTHandler; - -use base qw(PVE::RESTHandler); - -__PACKAGE__->register_method ({ - name => 'readovf', - path => '', - method => 'GET', - proxyto => 'node', - description => "Read an .ovf manifest.", - protected => 1, - parameters => { - additionalProperties => 0, - properties => { - node => get_standard_option('pve-node'), - manifest => { - description => "Path to .ovf manifest.", - type => 'string', - }, - }, - }, - returns => { - type => 'object', - additionalProperties => 1, - properties => PVE::QemuServer::json_ovf_properties(), - description => "VM config according to .ovf manifest.", - }, - code => sub { - my ($param) = @_; - - my $manifest = $param->{manifest}; - die "check for file $manifest failed - $!\n" if !-f $manifest; - - my $parsed = PVE::QemuServer::OVF::parse_ovf($manifest); - my $result; - $result->{cores} = $parsed->{qm}->{cores}; - $result->{name} = $parsed->{qm}->{name}; - $result->{memory} = $parsed->{qm}->{memory}; - my $disks = $parsed->{disks}; - for my $disk (@$disks) { - $result->{$disk->{disk_address}} = $disk->{backing_file}; - } - return $result; - }}); - -1; -- 2.39.2