From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.gruenbichler@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A344896BB5 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:20:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 842F21A35F for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:20:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:20:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 752C6450BC for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:20:56 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com> To: pve-devel@lists.proxmox.com Date: Tue, 16 Apr 2024 14:20:35 +0200 Message-Id: <20240416122054.733817-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 qemu-server/pve-container 0/19] pool resource limits X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 16 Apr 2024 12:20:58 -0000 high level description: VM/CT vmstatus returns new fields for configured and running "usage" values, these are then broadcasted by pvestatd on each node via KV. helpers in guest-common to check those limits pool API returns limits and usage, them and allows setting the limits qemu-server/pve-container try to check actions against those limits. since the broadcast is async, there is always an opportunity to cheat by racing against the broadcast. this is unavoidable unless we want to serialize all usage affecting tasks across the cluster.. changelog since v1/RFC: - GUI can edit limits now - incorporated most feedback from Wolfgang and Dominik potential follow-ups: - disk limits/usage - RRD/metrics support (or even switching entirely to RRD based broadcasting instead of KV) - timeout of broadcasted data if node goes offline/stops broadcasting - better GUI - ... ? pve-access-control: Fabian Grünbichler (1): pools: define resource limits src/PVE/AccessControl.pm | 42 +++++++++++++++++++++++++++++++++++++-- src/test/parser_writer.pl | 14 ++++++------- 2 files changed, 47 insertions(+), 9 deletions(-) pve-container: Fabian Grünbichler (7): config: add pool usage helper status: add pool usage fields create/restore/clone: handle pool limits start: handle pool limits hotplug: handle pool limits rollback: handle pool limits update: handle pool limits src/PVE/API2/LXC.pm | 25 +++++++++++++++++++ src/PVE/API2/LXC/Config.pm | 21 ++++++++++++++++ src/PVE/API2/LXC/Snapshot.pm | 7 ++++++ src/PVE/LXC.pm | 37 +++++++++++++++++++++++++++ src/PVE/LXC/Config.pm | 48 ++++++++++++++++++++++++++++++++++++ 5 files changed, 138 insertions(+) pve-guest-common: Fabian Grünbichler (1): helpers: add pool limit/usage helpers src/PVE/GuestHelpers.pm | 183 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 183 insertions(+) pve-manager: Fabian Grünbichler (4): api: pools: add limits management pvestatd: collect and broadcast pool usage api: return pool usage when queried ui: add pool limits and usage PVE/API2/Pool.pm | 65 ++++++++++++++- PVE/Service/pvestatd.pm | 59 ++++++++++++- www/manager6/pool/StatusView.js | 141 +++++++++++++++++++++++++++++++- 3 files changed, 256 insertions(+), 9 deletions(-) qemu-server: Fabian Grünbichler (6): config: add pool usage helper vmstatus: add usage values for pool limits create/restore/clone: handle pool limits update/hotplug: handle pool limits start: handle pool limits rollback: handle pool limits PVE/API2/Qemu.pm | 54 ++++++++++++++++++++++++++++++++++++++++ PVE/QemuConfig.pm | 30 ++++++++++++++++++++++ PVE/QemuServer.pm | 49 ++++++++++++++++++++++++++++++++++++ PVE/QemuServer/Memory.pm | 6 +++++ 4 files changed, 139 insertions(+)