From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.schauer@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9EB5896AD9 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:10:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2868F191E6 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:10:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:10:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5E15645029 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 14:10:07 +0200 (CEST) From: Filip Schauer <f.schauer@proxmox.com> To: pve-devel@lists.proxmox.com Date: Tue, 16 Apr 2024 14:10:00 +0200 Message-Id: <20240416121002.135845-1-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v4 manager 0/2] add edit window for device passthrough X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 16 Apr 2024 12:10:08 -0000 Changes since v3: * Pass confid in via cbind instead of manually setting it in the view model * Check me.isCreate instead of !me.confid for whether to find the next free device slot Changes since v2: * Clarify naming of mount point and device passthrough related utils * Remove unnecessary cbind * Make the device index selectible * Add default values as emptyText to the UI elements * Reorder UI elements to improve the layout * Disable the Device Passthrough menu entries for non-root users * Change var to let * Minor code cleanup of DeviceEdit.js Changes since v1: * Remove usb mapping * Add mode, uid and gid fields Filip Schauer (2): utils: clarify naming of LXC mount point utils ui: lxc: add edit window for device passthrough www/manager6/Makefile | 1 + www/manager6/Utils.js | 23 ++- www/manager6/lxc/DeviceEdit.js | 180 +++++++++++++++++++++++ www/manager6/lxc/MPEdit.js | 4 +- www/manager6/lxc/MultiMPEdit.js | 4 +- www/manager6/lxc/Resources.js | 33 ++++- www/manager6/window/GuestDiskReassign.js | 6 +- 7 files changed, 236 insertions(+), 15 deletions(-) create mode 100644 www/manager6/lxc/DeviceEdit.js -- 2.39.2