From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 322EC96B0B for ; Tue, 16 Apr 2024 14:10:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04743191A0 for ; Tue, 16 Apr 2024 14:10:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 16 Apr 2024 14:10:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8FE5D450CF for ; Tue, 16 Apr 2024 14:10:01 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 16 Apr 2024 14:09:54 +0200 Message-Id: <20240416120957.75269-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240416120957.75269-1-f.ebner@proxmox.com> References: <20240416120957.75269-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v4 manager 4/5] ui: backup job: disable zstd thread count field when zstd isn't used X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2024 12:10:33 -0000 Also need to check for enable/disable of the compression selector, because with PBS the value zstd is set, but the thread count setting doesn't apply. Suggested-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- Changes in v4: * adapt to rename backupPerformance -> backupAdvanced www/manager6/dc/Backup.js | 18 ++++++++++++++++++ www/manager6/panel/BackupAdvancedOptions.js | 13 +++++++++++++ 2 files changed, 31 insertions(+) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index aaa319f4..221fe17c 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -145,6 +145,18 @@ Ext.define('PVE.dc.BackupEdit', { } }, + compressionChange: function(f, value, oldValue) { + this.getView().lookup('backupAdvanced').updateCompression(value, f.isDisabled()); + }, + + compressionDisable: function(f) { + this.getView().lookup('backupAdvanced').updateCompression(f.getValue(), true); + }, + + compressionEnable: function(f) { + this.getView().lookup('backupAdvanced').updateCompression(f.getValue(), false); + }, + init: function(view) { let me = this; if (view.isCreate) { @@ -359,6 +371,11 @@ Ext.define('PVE.dc.BackupEdit', { deleteEmpty: '{!isCreate}', }, value: 'zstd', + listeners: { + change: 'compressionChange', + disable: 'compressionDisable', + enable: 'compressionEnable', + }, }, { xtype: 'pveBackupModeSelector', @@ -473,6 +490,7 @@ Ext.define('PVE.dc.BackupEdit', { }, { xtype: 'pveBackupAdvancedOptionsPanel', + reference: 'backupAdvanced', title: gettext('Advanced'), cbind: { isCreate: '{isCreate}', diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js index 4d74ba3d..11a39352 100644 --- a/www/manager6/panel/BackupAdvancedOptions.js +++ b/www/manager6/panel/BackupAdvancedOptions.js @@ -12,6 +12,10 @@ Ext.define('PVE.panel.BackupAdvancedOptions', { return {}; }, + controller: { + xclass: 'Ext.app.ViewController', + }, + onGetValues: function(formValues) { if (this.needMask) { // isMasked() may not yet be true if not rendered once return {}; @@ -54,6 +58,14 @@ Ext.define('PVE.panel.BackupAdvancedOptions', { return options; }, + updateCompression: function(value, disabled) { + if (!disabled && value === 'zstd') { + this.lookup('zstdThreadCount').setDisabled(false); + } else { + this.lookup('zstdThreadCount').setDisabled(true); + } + }, + column1: [ { xtype: 'pveBandwidthField', @@ -71,6 +83,7 @@ Ext.define('PVE.panel.BackupAdvancedOptions', { { xtype: 'proxmoxintegerfield', name: 'zstd', + reference: 'zstdThreadCount', fieldLabel: Ext.String.format(gettext('{0} Threads'), 'Zstd'), fieldStyle: 'text-align: right', emptyText: gettext('use fallback'), -- 2.39.2