From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.schauer@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7EAE396347 for <pve-devel@lists.proxmox.com>; Mon, 15 Apr 2024 15:17:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E6DCA622 for <pve-devel@lists.proxmox.com>; Mon, 15 Apr 2024 15:17:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Mon, 15 Apr 2024 15:17:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 08BD544A3C for <pve-devel@lists.proxmox.com>; Mon, 15 Apr 2024 15:17:09 +0200 (CEST) From: Filip Schauer <f.schauer@proxmox.com> To: pve-devel@lists.proxmox.com Date: Mon, 15 Apr 2024 15:17:00 +0200 Message-Id: <20240415131702.94922-1-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH common/container v2 0/2] fix invalid device passthrough being added to config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 15 Apr 2024 13:17:40 -0000 Fix a bug that allows a device passthrough entry to be added to the config despite the device path not pointing to a device. Previously, adding an invalid device passthrough entry would throw an error, but the entry would still be added to the config. This is fixed by moving the respective checks from update_lxc_config to update_pct_config, which is run before the entry is written to the config file. Changes since v1: * Use "if" instead of "unless" * Move device path validation and stat to seperate helper function pve-common: Filip Schauer (1): add get_device_stat helper subroutine src/PVE/Tools.pm | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) pve-container: Filip Schauer (1): fix invalid device passthrough being added to config src/PVE/LXC.pm | 18 ++++-------------- src/PVE/LXC/Config.pm | 11 ++++++++++- 2 files changed, 14 insertions(+), 15 deletions(-) Summary over all repositories: 3 files changed, 31 insertions(+), 16 deletions(-) -- Generated by git-murpp 0.6.0