From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EA16D96210 for ; Mon, 15 Apr 2024 12:30:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C4C1377D6 for ; Mon, 15 Apr 2024 12:30:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 15 Apr 2024 12:30:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BD19A44392 for ; Mon, 15 Apr 2024 12:30:28 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 15 Apr 2024 12:30:27 +0200 Message-Id: <20240415103027.3000412-9-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240415103027.3000412-1-d.csapak@proxmox.com> References: <20240415103027.3000412-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-flutter-frontend 5/5] improve back button behavior X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2024 10:30:31 -0000 by using 'SystemNavigator.pop()' on the top level page when pressing the back button. On Android this minimizes/closes the app an presents whatever was shown before. This fixes an issue where we would show a blank screen when pressing the back button on the dashboard. Signed-off-by: Dominik Csapak --- not sure if this is the fix that we want, but i did not find any other way. It seems that using PopScope does not really handle popping the last route correctly. Also, this will not work for iOS (but since we don't provide the app there, probably irrelevant) lib/pages/main_layout_slim.dart | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/pages/main_layout_slim.dart b/lib/pages/main_layout_slim.dart index ec80dba..1761b26 100644 --- a/lib/pages/main_layout_slim.dart +++ b/lib/pages/main_layout_slim.dart @@ -1,5 +1,6 @@ import 'package:built_collection/built_collection.dart'; import 'package:flutter/material.dart'; +import 'package:flutter/services.dart'; import 'package:font_awesome_flutter/font_awesome_flutter.dart'; import 'package:intl/intl.dart'; import 'package:provider/provider.dart'; @@ -74,7 +75,8 @@ class _MainLayoutSlimState extends State { if (pageSelector.value != 0) pageSelector.add(0); return; } - if (mounted) Navigator.of(context).pop(); + // minimize/return from the app + SystemNavigator.pop(); }, child: StreamBuilder( stream: pageSelector.stream, -- 2.39.2