From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2BD8D95817 for ; Fri, 12 Apr 2024 14:26:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0CF17A633 for ; Fri, 12 Apr 2024 14:26:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Apr 2024 14:26:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2C12E4501A for ; Fri, 12 Apr 2024 14:26:48 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 12 Apr 2024 14:26:40 +0200 Message-Id: <20240412122640.146893-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu] Makefile: drop -j option from dpkg-buildpackage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2024 12:26:49 -0000 >From man dpkg-buildpackage: > -j, --jobs[=jobs|auto] > Specifies the number of jobs allowed to be run simultaneously (since > dpkg 1.14.7, long option since dpkg 1.18.8). The number of jobs > matching the number of online processors if auto is specified (since > dpkg 1.17.10), or unlimited number if jobs is not specified. The > default behavior is auto (since dpkg 1.18.11) in non-forced mode > (since dpkg 1.21.10), and as such it is always safer to use with any > package including those that are not parallel-build safe. The option was added in the Makefile by commit 4ba321f ("build qemu multithreaded") which states: > same as in pve-kernel where we have --jobs=auto But according to the man page, -j without an argument is not the same and means unlimited. Using the number of online cores seems more sensible and was the original intention. Again, according to the man page, the default is auto since dpkg 1.18.11 (or Debian Stretch), so just drop the option. The motivation to look into this was that after the recent upstream commit d1ce2cc95b ("Makefile: preserve --jobserver-auth argument when calling ninja") having -j as the make flag would be broken as it was mistakenly passed to ninja (for which the argument for -j is not optional). Should get fixed soon [0]. [0]: https://lore.kernel.org/qemu-devel/20240412100401.20047-2-pbonzini@redhat.com/T/#u Signed-off-by: Fiona Ebner --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index cad130e..c05c641 100644 --- a/Makefile +++ b/Makefile @@ -56,7 +56,7 @@ $(BUILDDIR): submodule deb kvm: $(DEBS) $(DEB_DBG): $(DEB) $(DEB): $(BUILDDIR) - cd $(BUILDDIR); dpkg-buildpackage -b -us -uc -j + cd $(BUILDDIR); dpkg-buildpackage -b -us -uc lintian $(DEBS) sbuild: $(DSC) -- 2.39.2