From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 15F0D956EB for ; Fri, 12 Apr 2024 13:08:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E30AE8EE4 for ; Fri, 12 Apr 2024 13:08:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Apr 2024 13:08:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7E9BE4510E for ; Fri, 12 Apr 2024 13:08:20 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 12 Apr 2024 13:08:14 +0200 Message-Id: <20240412110814.46684-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240412110814.46684-1-f.ebner@proxmox.com> References: <20240412110814.46684-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pct.pm] Subject: [pve-devel] [PATCH v2 container 3/3] pct: fsck: add missing call to activate volume X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2024 11:08:52 -0000 Otherwise, running pct fsck for e.g. an LVM volume after shutting down a container would fail. The container is not running, so the volume should be deactivated afterwards. Suggested-by: Fabian Grünbichler Signed-off-by: Fiona Ebner --- New in v2. src/PVE/CLI/pct.pm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index 13aa4c1..c48321d 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -287,6 +287,7 @@ __PACKAGE__->register_method ({ die "unable to run fsck for '$volid' (format == $format)\n" if $format ne 'raw'; + PVE::Storage::activate_volumes($storage_cfg, [$volid]); $path = PVE::Storage::map_volume($storage_cfg, $volid); } else { @@ -302,8 +303,12 @@ __PACKAGE__->register_method ({ eval { PVE::Tools::run_command($command); }; my $err = $@; - eval { PVE::Storage::unmap_volume($storage_cfg, $volid) if $storage_id; }; - warn $@ if $@; + if ($storage_id) { + eval { PVE::Storage::unmap_volume($storage_cfg, $volid); }; + warn $@ if $@; + eval { PVE::Storage::deactivate_volumes($storage_cfg, [$volid]); }; + warn $@ if $@; + } die $err if $err; }; -- 2.39.2