From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 80A449525D for ; Fri, 12 Apr 2024 10:05:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5FCDE5603 for ; Fri, 12 Apr 2024 10:05:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Apr 2024 10:05:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C2C7944FCA for ; Fri, 12 Apr 2024 10:04:59 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 12 Apr 2024 10:04:52 +0200 Message-Id: <20240412080458.1066580-4-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240412080458.1066580-1-d.csapak@proxmox.com> References: <20240412080458.1066580-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-flutter-frontend 3/9] node overview: don't throw permission errors on every update X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2024 08:05:03 -0000 getting the apt update status requires Sys.Modify, but the user does not necessarily has that. So instead of showing a pop up every 10 seconds, simply ignore permission errors and only show other exceptions here. Signed-off-by: Dominik Csapak --- lib/bloc/pve_node_overview_bloc.dart | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/bloc/pve_node_overview_bloc.dart b/lib/bloc/pve_node_overview_bloc.dart index 7a093b0..caeb1c4 100644 --- a/lib/bloc/pve_node_overview_bloc.dart +++ b/lib/bloc/pve_node_overview_bloc.dart @@ -40,8 +40,15 @@ class PveNodeOverviewBloc yield latestState.rebuild((b) => b..rrdData.replace(rrdData)); final services = await apiClient.getNodeServices(nodeID); yield latestState.rebuild((b) => b..services.replace(services)); - final updates = await apiClient.getNodeAptUpdate(nodeID); - yield latestState.rebuild((b) => b..updates.replace(updates)); + try { + final updates = await apiClient.getNodeAptUpdate(nodeID); + yield latestState.rebuild((b) => b..updates.replace(updates)); + } on ProxmoxApiException catch (e) { + // only throw on non permission related errors + if (e.statusCode != 403) { + rethrow; + } + } final disks = await apiClient.getNodeDisksList(nodeID); yield latestState.rebuild((b) => b..disks.replace(disks)); } -- 2.39.2