From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 258AA95262 for ; Fri, 12 Apr 2024 10:05:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DFD9255E5 for ; Fri, 12 Apr 2024 10:05:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Apr 2024 10:05:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 95D1744F69 for ; Fri, 12 Apr 2024 10:05:00 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 12 Apr 2024 10:04:58 +0200 Message-Id: <20240412080458.1066580-10-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240412080458.1066580-1-d.csapak@proxmox.com> References: <20240412080458.1066580-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-flutter-frontend 9/9] task log list: make warning icon more distinct X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2024 08:05:08 -0000 by making it rounded (which appears as 'less dangerous'). Sadly the 'error' icon is not really usable for us, since it looks almost the same as the 'info' icon (just 180 degree rotated). We could use an 'outline' variant for either, but making the 'less dangerous' one rounded feels alright. Signed-off-by: Dominik Csapak --- lib/widgets/pve_task_log_expansiontile_widget.dart | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/widgets/pve_task_log_expansiontile_widget.dart b/lib/widgets/pve_task_log_expansiontile_widget.dart index 2ff5eb2..6491b6b 100644 --- a/lib/widgets/pve_task_log_expansiontile_widget.dart +++ b/lib/widgets/pve_task_log_expansiontile_widget.dart @@ -67,7 +67,11 @@ class _PveTaskExpansionTileState extends State { collapsedBackgroundColor: Theme.of(context).colorScheme.background, key: PageStorageKey(widget.task), leading: Icon( - hasError || hasWarnings ? Icons.warning : Icons.info, + hasError + ? Icons.warning + : hasWarnings + ? Icons.warning_rounded + : Icons.info, color: hasError ? errorColor : hasWarnings -- 2.39.2