From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 349D094E9A for ; Thu, 11 Apr 2024 13:16:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 12FC63037A for ; Thu, 11 Apr 2024 13:16:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 11 Apr 2024 13:16:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 089E044B02 for ; Thu, 11 Apr 2024 13:16:10 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 11 Apr 2024 13:16:04 +0200 Message-Id: <20240411111606.73267-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240411111606.73267-1-f.ebner@proxmox.com> References: <20240411111606.73267-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH v2 qemu-server 2/4] mirror: do not auto-dismiss to allow getting error message from job X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2024 11:16:11 -0000 upon failure. Otherwise, the job would disappear too quickly from the job list and cannot be queried for the actual error anymore. Relevant part of the error in actual examples (note that the fact that it's a mirror job is already mentioned earlier in the full error, with "block job (mirror) error:"): Before: > 'mirror' has been cancelled > 'mirror' has been cancelled After: > Source and target image have different sizes (io-status: ok) > No space left on device (io-status: ok) Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index e5543237..77aaf718 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7907,7 +7907,14 @@ sub qemu_drive_mirror { $qemu_target = $is_zero_initialized ? "zeroinit:$dst_path" : $dst_path; } - my $opts = { timeout => 10, device => "drive-$drive", mode => "existing", sync => "full", target => $qemu_target }; + my $opts = { + timeout => 10, + device => "drive-$drive", + mode => "existing", + sync => "full", + target => $qemu_target, + 'auto-dismiss' => JSON::false, + }; $opts->{format} = $format if $format; if (defined($src_bitmap)) { -- 2.39.2