From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 341A494E99 for ; Thu, 11 Apr 2024 13:16:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 165CB30425 for ; Thu, 11 Apr 2024 13:16:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 11 Apr 2024 13:16:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C9E9844B1E for ; Thu, 11 Apr 2024 13:16:09 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 11 Apr 2024 13:16:02 +0200 Message-Id: <20240411111606.73267-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH-SERIES v2 qemu-server] improve error detection/messages for some block jobs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2024 11:16:11 -0000 Changes in v2: * Also do not auto-dismiss for the stream job for the new live-import feature. When auto-dismiss=true (the default), a failed job can disappear very quickly from the job list and there might not be any chance to see the error in the result of 'query-block-jobs'. For jobs with $completion being 'auto', like 'block-stream', it couldn't even be detected that the job failed. Jobs with auto-dismiss=false on the other hand, will wait in 'concluded' state until manually dismissed. For those, it will be possible to query the error if the job failed. This series makes 'drive-mirror' and 'block-stream' jobs do just that. There doesn't seem to be a way to have only failed jobs stay around, e.g. something like auto-dismiss=on-success. Fiona Ebner (4): blockjob: anticipate jobs with auto-dismiss=false for better error messages and detection mirror: do not auto-dismiss to allow getting error message from job live restore: do not auto-dismiss stream job to improve error message and detection live import: do not auto-dismiss stream job to improve error message and detection PVE/QemuServer.pm | 35 +++++++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) -- 2.39.2