From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.gruenbichler@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 8B50D94D79
for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 12:10:50 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6BAE91F100
for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 12:10:50 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 12:10:49 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AC95344A30
for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 12:10:49 +0200 (CEST)
From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu, 11 Apr 2024 12:10:48 +0200
Message-Id: <20240411101048.305510-1-f.gruenbichler@proxmox.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.057 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager] d/postinst: make deb-systemd-invoke
non-fatal
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2024 10:10:50 -0000
else this can break an upgrade for unrelated reasons (regular debhelper also
constructs the restart invocations like this, it even redirects output to
/dev/null)
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
debian/postinst | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/debian/postinst b/debian/postinst
index 6138ef6d0..2799f581c 100755
--- a/debian/postinst
+++ b/debian/postinst
@@ -123,11 +123,11 @@ case "$1" in
# the ExecStartPre doesn't triggers on service reload, so just in case
pvecm updatecerts --silent || true
- deb-systemd-invoke reload-or-try-restart pvedaemon.service
- deb-systemd-invoke reload-or-try-restart pvestatd.service
- deb-systemd-invoke reload-or-try-restart pveproxy.service
- deb-systemd-invoke reload-or-try-restart spiceproxy.service
- deb-systemd-invoke reload-or-try-restart pvescheduler.service
+ deb-systemd-invoke reload-or-try-restart pvedaemon.service || true
+ deb-systemd-invoke reload-or-try-restart pvestatd.service || true
+ deb-systemd-invoke reload-or-try-restart pveproxy.service || true
+ deb-systemd-invoke reload-or-try-restart spiceproxy.service || true
+ deb-systemd-invoke reload-or-try-restart pvescheduler.service || true
exit 0;;
@@ -199,7 +199,7 @@ case "$1" in
dh_action="start"
fi
if systemctl -q is-enabled "$unit"; then
- deb-systemd-invoke $dh_action "$unit"
+ deb-systemd-invoke $dh_action "$unit" || true
fi
done
fi
--
2.39.2