From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 51930940A0 for ; Wed, 10 Apr 2024 13:04:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 989C2CD4C for ; Wed, 10 Apr 2024 13:04:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 10 Apr 2024 13:04:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EBB7943C8D for ; Wed, 10 Apr 2024 13:04:04 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 10 Apr 2024 13:03:49 +0200 Message-Id: <20240410110401.2226201-11-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240410110401.2226201-1-d.csapak@proxmox.com> References: <20240410110401.2226201-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v2 05/10] vm_stop_cleanup: add noerr parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2024 11:04:11 -0000 and set it on all current users Signed-off-by: Dominik Csapak --- PVE/CLI/qm.pm | 2 +- PVE/QemuServer.pm | 13 ++++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm index b105830f..fbc590f5 100755 --- a/PVE/CLI/qm.pm +++ b/PVE/CLI/qm.pm @@ -933,7 +933,7 @@ __PACKAGE__->register_method({ if (!$clean || $guest) { # vm was shutdown from inside the guest or crashed, doing api cleanup - PVE::QemuServer::vm_stop_cleanup($storecfg, $vmid, $conf, 0, 0); + PVE::QemuServer::vm_stop_cleanup($storecfg, $vmid, $conf, 0, 0, 1); } PVE::GuestHelpers::exec_hookscript($conf, $vmid, 'post-stop'); diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 8a71e8aa..771bef82 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6158,7 +6158,7 @@ sub cleanup_pci_devices { } sub vm_stop_cleanup { - my ($storecfg, $vmid, $conf, $keepActive, $apply_pending_changes) = @_; + my ($storecfg, $vmid, $conf, $keepActive, $apply_pending_changes, $noerr) = @_; eval { @@ -6184,7 +6184,10 @@ sub vm_stop_cleanup { vmconfig_apply_pending($vmid, $conf, $storecfg) if $apply_pending_changes; }; - warn $@ if $@; # avoid errors - just warn + if (my $err = $@) { + die $err if !$noerr; + warn $err; + } } # call only in locked context @@ -6235,7 +6238,7 @@ sub _do_vm_stop { die "VM quit/powerdown failed - got timeout\n"; } } else { - vm_stop_cleanup($storecfg, $vmid, $conf, $keepActive, 1) if $conf; + vm_stop_cleanup($storecfg, $vmid, $conf, $keepActive, 1, 1) if $conf; return; } } else { @@ -6266,7 +6269,7 @@ sub _do_vm_stop { sleep 1; } - vm_stop_cleanup($storecfg, $vmid, $conf, $keepActive, 1) if $conf; + vm_stop_cleanup($storecfg, $vmid, $conf, $keepActive, 1, 1) if $conf; } # Note: use $nocheck to skip tests if VM configuration file exists. @@ -6281,7 +6284,7 @@ sub vm_stop { my $pid = check_running($vmid, $nocheck, $migratedfrom); kill 15, $pid if $pid; my $conf = PVE::QemuConfig->load_config($vmid, $migratedfrom); - vm_stop_cleanup($storecfg, $vmid, $conf, $keepActive, 0); + vm_stop_cleanup($storecfg, $vmid, $conf, $keepActive, 0, 1); return; } -- 2.39.2