From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 0D15694012
for <pve-devel@lists.proxmox.com>; Wed, 10 Apr 2024 13:04:05 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E8F7ACADF
for <pve-devel@lists.proxmox.com>; Wed, 10 Apr 2024 13:04:04 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Wed, 10 Apr 2024 13:04:03 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D483343C92
for <pve-devel@lists.proxmox.com>; Wed, 10 Apr 2024 13:04:02 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Wed, 10 Apr 2024 13:03:39 +0200
Message-Id: <20240410110401.2226201-1-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.014 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH guest-common/qemu-server/manager/docs v2]
implement experimental vgpu live migration
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2024 11:04:05 -0000
and some useful cleanups
this series replaces both the initial pci live migration and the
fixup series[0][1]
This is implemented for mapped resources. This requires driver and
hardware support, but aside from nvidia vgpus there don't seem to be
many drivers (if any) that do support that.
qemu already supports that for vfio-pci devices, so nothing to be
done there besides actively enabling it.
Since we currently can't properly test it here and very much depends on
hardware/driver support, mark it as experimental everywhere (docs/api/gui).
(though i tested the live-migration part manually here by using
"exec:cat > /tmp/test" for the migration target, and "exec: cat
/tmp/test" as the 'incoming' parameter for a new vm start, which worked ;) )
i opted for marking them migratable at the mapping level, but we could
theoretically also put it in the hostpciX config instead.
(though imho it fits better in the cluster-wide resource mapping config)
also the naming/texts could probably be improved, but i think
'live-migration-capable' is very descriptive and i didn't want to
use an overly short name for it (which can be confusing, see the
'shared' flag for storages)
the first 3 patches of guest-common, the first 6 patches of qemu-server
and the first 2 of pve-manager, only tangentially relate to the actual
title of this series and could be applied independently, since they're
mostly cleanups & code move
though qemu-server 3/10 and pve-manager 1/5 depend on the
pve-guest-common 2-3/5
also pve-manager 4/5 depends on all of qemu-server
0: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062226.html
1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062293.html
pve-guest-common:
Dominik Csapak (5):
mapping: pci: fix missing description/default for mdev
mapping: pci: rework properties check
mapping: pci: check the mdev configuration on the device too
mapping: pci: add 'live-migration-capable' flag to mappings
mapping: remove find_on_current_node
src/PVE/Mapping/PCI.pm | 69 ++++++++++++++++++++++++------------------
src/PVE/Mapping/USB.pm | 9 ------
2 files changed, 40 insertions(+), 38 deletions(-)
qemu-server:
Dominik Csapak (10):
usb: mapping: move implementation of find_on_current_node here
pci: mapping: move implementation of find_on_current_node here
pci: mapping: check mdev config against hardware
stop cleanup: remove unnecessary tpmstate cleanup
vm_stop_cleanup: add noerr parameter
migrate: call vm_stop_cleanup after stopping in phase3_cleanup
pci: set 'enable-migration' to on for live-migration marked mapped
devices
check_local_resources: add more info per mapped device and return as
hash
api: enable live migration for marked mapped pci devices
api: include not mapped resources for running vms in migrate
preconditions
PVE/API2/Qemu.pm | 48 ++++++++++++++++++++++--------------
PVE/CLI/qm.pm | 2 +-
PVE/QemuMigrate.pm | 28 ++++++++++++---------
PVE/QemuServer.pm | 38 ++++++++++++++--------------
PVE/QemuServer/PCI.pm | 14 +++++++++--
PVE/QemuServer/USB.pm | 5 +++-
test/MigrationTest/Shared.pm | 3 +++
7 files changed, 84 insertions(+), 54 deletions(-)
pve-manager:
Dominik Csapak (5):
mapping: pci: include mdev in config checks
bulk migrate: improve precondition checks
bulk migrate: include checks for live-migratable local resources
ui: adapt migration window to precondition api change
fix #5175: ui: allow configuring and live migration of mapped pci
resources
PVE/API2/Cluster/Mapping/PCI.pm | 2 +-
PVE/API2/Nodes.pm | 27 ++++++++++++++--
www/manager6/dc/PCIMapView.js | 5 +++
www/manager6/window/Migrate.js | 51 ++++++++++++++++++++-----------
www/manager6/window/PCIMapEdit.js | 12 ++++++++
5 files changed, 75 insertions(+), 22 deletions(-)
pve-docs:
Dominik Csapak (2):
qm: resource mapping: add description for `mdev` option
qm: resource mapping: document `live-migration-capable` setting
qm.adoc | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
--
2.39.2