From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AC57C90EF8 for ; Wed, 3 Apr 2024 11:11:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8DE6B14873 for ; Wed, 3 Apr 2024 11:11:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 3 Apr 2024 11:11:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D932444CD8 for ; Wed, 3 Apr 2024 11:10:59 +0200 (CEST) From: Friedrich Weber To: pve-devel@lists.proxmox.com Date: Wed, 3 Apr 2024 11:10:09 +0200 Message-Id: <20240403091010.11544-3-f.weber@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240403091010.11544-1-f.weber@proxmox.com> References: <20240403091010.11544-1-f.weber@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/3] ui: pool members: avoid sharing object for extra request parameters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2024 09:11:30 -0000 Currently, all instances of `PVE.pool.AddVM` in a session share the same `extraRequestParams` object. Right now, this does not cause any problems because only one window can be active at a time, and all relevant keys are always overwritten. Still, in order to avoid hard-to-catch bugs due to the shared object in the future, create a new `extraRequestParams` object for each instance of `PVE.pool.AddVM`. Signed-off-by: Friedrich Weber --- Notes: new in v2 www/manager6/grid/PoolMembers.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js index af6af1bd..4ffcde7f 100644 --- a/www/manager6/grid/PoolMembers.js +++ b/www/manager6/grid/PoolMembers.js @@ -6,10 +6,6 @@ Ext.define('PVE.pool.AddVM', { isAdd: true, isCreate: true, - extraRequestParams: { - 'allow-move': 1, - }, - initComponent: function() { var me = this; @@ -19,7 +15,10 @@ Ext.define('PVE.pool.AddVM', { me.url = '/pools/'; me.method = 'PUT'; - me.extraRequestParams.poolid = me.pool; + me.extraRequestParams = { + 'allow-move': 1, + poolid: me.pool, + }; var vmsField = Ext.create('Ext.form.field.Text', { name: 'vms', -- 2.39.2