From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 431E8BC604 for ; Thu, 28 Mar 2024 14:51:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9410ECBCA for ; Thu, 28 Mar 2024 14:50:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 28 Mar 2024 14:50:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 28CA94297D for ; Thu, 28 Mar 2024 14:50:34 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Thu, 28 Mar 2024 14:50:26 +0100 Message-Id: <20240328135028.504520-29-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240328135028.504520-1-a.lauterer@proxmox.com> References: <20240328135028.504520-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v3 28/30] common: skip target_hd when deserializing InstallConfig X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2024 13:51:10 -0000 as only the 'path' property is serialized -> deserialization is problematic. The information would be present in the 'run-env-info-json', but for now there is no need for it in any code that deserializes the low-level config. Therefore we are currently skipping it on deserialization If we need it in the future, we need to think about how to handle the deserialization. Signed-off-by: Aaron Lauterer --- proxmox-installer-common/src/setup.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/proxmox-installer-common/src/setup.rs b/proxmox-installer-common/src/setup.rs index 743e7a9..f9f9e82 100644 --- a/proxmox-installer-common/src/setup.rs +++ b/proxmox-installer-common/src/setup.rs @@ -414,7 +414,12 @@ pub struct InstallConfig { #[serde( serialize_with = "serialize_disk_opt", - skip_serializing_if = "Option::is_none" + skip_serializing_if = "Option::is_none", + // only the 'path' property is serialized -> deserialization is problematic + // The information would be present in the 'run-env-info-json', but for now there is no + // need for it in any code that deserializes the low-level config. Therefore we are + // currently skipping it on deserialization + skip_deserializing )] pub target_hd: Option, #[serde(skip_serializing_if = "BTreeMap::is_empty")] -- 2.39.2