From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1472DBBC1F for ; Tue, 26 Mar 2024 14:31:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E4F7A14A97 for ; Tue, 26 Mar 2024 14:31:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 26 Mar 2024 14:31:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E2C1642175 for ; Tue, 26 Mar 2024 14:31:09 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 26 Mar 2024 14:29:19 +0100 Message-ID: <20240326133103.952802-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.43.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [test.pl, runenv.pm, proxmox.com] Subject: [pve-devel] [PATCH installer] run env: use default error message if country detection failed with empty string X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2024 13:31:11 -0000 Bit of perl fun again. $err from detect_country_tracing_to() can be empty string under certain circumstances (according to a forum post [0]). The // operator evaluates an empty as true, thus `warn` receives an empty string to and just prints Warning: something wrong at /usr/share/perl5/proxmox/Install/RunEnv.pm line 305 Which isn't particular helpful. Use the || operator instead, that evaluates an empty string as false and thus would fall back to the generic error message. A minimal reproducer/example for completeness sake: #!/usr/bin/env perl use strict; use warnings; warn ('' // "unable to detect country\n"); warn ('' || "unable to detect country\n"); gives Warning: something's wrong at ./test.pl line 5. unable to detect country [0] https://forum.proxmox.com/threads/blank-screen-while-installing.143928/ Signed-off-by: Christoph Heiss --- Proxmox/Install/RunEnv.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Proxmox/Install/RunEnv.pm b/Proxmox/Install/RunEnv.pm index 25b6bb3..39505d0 100644 --- a/Proxmox/Install/RunEnv.pm +++ b/Proxmox/Install/RunEnv.pm @@ -302,7 +302,7 @@ sub query_installation_environment : prototype() { if (defined($country)) { $output->{country} = $country; } else { - warn ($err // "unable to detect country\n"); + warn ($err || "unable to detect country\n"); } return $output; -- 2.43.1