From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 82AC9BB716 for ; Mon, 25 Mar 2024 12:00:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6543E230F for ; Mon, 25 Mar 2024 12:00:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 25 Mar 2024 12:00:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8281841DD1 for ; Mon, 25 Mar 2024 12:00:17 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 25 Mar 2024 12:00:12 +0100 Message-Id: <20240325110012.26547-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, lxc.pm] Subject: [pve-devel] [PATCH container] mountpoint mount: activate PVE-managed volumes during preparation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2024 11:00:51 -0000 Otherwise it was not possible to hotplug a volume that was previously deactivated and requires activation, e.g. an LVM LV that was detached after shutting down the container couldn't be hotplugged anymore later. Signed-off-by: Fiona Ebner --- Requires the following patch to be tested on recent kernels: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061260.html src/PVE/LXC.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 7db4833..29ff418 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1849,6 +1849,7 @@ sub __mountpoint_mount { my $scfg = PVE::Storage::storage_config($storage_cfg, $storage); + PVE::Storage::activate_volumes($storage_cfg, [$volid]); my $path = PVE::Storage::map_volume($storage_cfg, $volid, $snapname); $path = PVE::Storage::path($storage_cfg, $volid, $snapname) if !defined($path); -- 2.39.2