From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <m.carrara@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 21E5FBB21C for <pve-devel@lists.proxmox.com>; Fri, 22 Mar 2024 19:06:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 08453A32D for <pve-devel@lists.proxmox.com>; Fri, 22 Mar 2024 19:06:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Fri, 22 Mar 2024 19:06:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 18D0B41A91 for <pve-devel@lists.proxmox.com>; Fri, 22 Mar 2024 19:06:25 +0100 (CET) From: Max Carrara <m.carrara@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 22 Mar 2024 19:06:17 +0100 Message-Id: <20240322180624.441185-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, listvms.py, mypy-lang.org] Subject: [pve-devel] [PATCH v2 pve-esxi-import-tools 0/7] Improve listvms.py X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 22 Mar 2024 18:06:26 -0000 Improve listvms.py - Version 2 ============================== Notable Changes Since v1 ------------------------ * mypy [0] is now a build dependency and runs automatically on `make install` (and thus also on `make deb` etc.) * JSON output is now directly streamed to stdout via `json.dump()` instead of creating and printing a string For a detailed list of changes, please see the comments in the invididual patches. Older Versions -------------- v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062258.html References ---------- [0]: https://www.mypy-lang.org/ Summary of Changes ------------------ Max Carrara (7): listvms: remove unused import and variable listvms: reorder imports listvms: improve typing and add dataclasses to represent dicts listvms: add arg parser, context manager for connections, fetch helper listvms: dump json directly to stdout listvms: run formatter use mypy for automatic type checks in Python Makefile | 13 ++- debian/control | 1 + listvms.py | 300 +++++++++++++++++++++++++++++++++++++------------ mypy.ini | 8 ++ 4 files changed, 247 insertions(+), 75 deletions(-) create mode 100644 mypy.ini -- 2.39.2