From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EF098BA391 for ; Tue, 19 Mar 2024 14:01:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D07621F276 for ; Tue, 19 Mar 2024 14:00:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 19 Mar 2024 14:00:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B4B448AE2 for ; Tue, 19 Mar 2024 14:00:33 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 19 Mar 2024 14:00:30 +0100 Message-Id: <20240319130032.2192847-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240319130032.2192847-1-d.csapak@proxmox.com> References: <20240319130032.2192847-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 2/4] ui: guest import: auto activate virtio preparation for win + ovmf X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2024 13:01:08 -0000 it seems on esxi, most windows vms with uefi are automatically configured with an lsi scsi controller, which we can't currently support (ovmf driver issue) so automatically activate the sata mapping + virtio preparation in this case Signed-off-by: Dominik Csapak --- www/manager6/window/GuestImport.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js index 81e9074e..719bab31 100644 --- a/www/manager6/window/GuestImport.js +++ b/www/manager6/window/GuestImport.js @@ -644,7 +644,8 @@ Ext.define('PVE.window.GuestImport', { fieldLabel: gettext('Prepare for VirtIO-SCSI'), labelWidth: 200, reference: 'mapSata', - isFormField: false, + name: 'mapSata', + submitValue: false, disabled: true, bind: { disabled: '{!isWindows}', @@ -934,11 +935,15 @@ Ext.define('PVE.window.GuestImport', { me.getViewModel().set('warnings', data.warnings.map(w => renderWarning(w))); let osinfo = PVE.Utils.get_kvm_osinfo(me.vmConfig.ostype ?? ''); + let mapSata = (me.vmConfig.ostype ?? '').startsWith('w') && (me.vmConfig.bios ?? '').indexOf('ovmf') !== -1; me.setValues({ osbase: osinfo.base, ...me.vmConfig, }); + + + me.lookup('mapSata').setValue(mapSata); }, }); }, -- 2.39.2