From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CFABAB901A for ; Tue, 12 Mar 2024 12:59:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B184D16EE2 for ; Tue, 12 Mar 2024 12:59:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 12 Mar 2024 12:59:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 621E343E29 for ; Tue, 12 Mar 2024 12:59:25 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 12 Mar 2024 12:59:22 +0100 Message-Id: <20240312115922.101416-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240312115922.101416-1-f.ebner@proxmox.com> References: <20240312115922.101416-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH qemu-server 3/3] live restore: do not auto-dismiss stream job to improve error message and detection X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2024 11:59:56 -0000 upon failure. Otherwise, the job would disappear too quickly from the job list and cannot be queried for the actual error anymore. Relevant part of the error in an actual example: Before: > VM 112 qmp command 'blockdev-del' failed - Node 'drive-scsi0-pbs' is busy: node is used as backing hd of '#block046' After: > block job (stream) error: restore-drive-scsi0: No space left on device (io-status: ok) Note that previously, it was not even detected that the stream job failed and the error message is because the subsequent cleanup failed. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 664ae38e..51dfc0d9 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7252,6 +7252,7 @@ sub pbs_live_restore { mon_cmd($vmid, 'block-stream', 'job-id' => $job_id, device => "$ds", + 'auto-dismiss' => JSON::false, ); $jobs->{$job_id} = {}; } -- 2.39.2