From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <c.heiss@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 65D6CB8FCE
for <pve-devel@lists.proxmox.com>; Tue, 12 Mar 2024 12:59:52 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4605716EC8
for <pve-devel@lists.proxmox.com>; Tue, 12 Mar 2024 12:59:22 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Tue, 12 Mar 2024 12:59:21 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0790643E29
for <pve-devel@lists.proxmox.com>; Tue, 12 Mar 2024 12:59:21 +0100 (CET)
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Tue, 12 Mar 2024 12:59:12 +0100
Message-ID: <20240312115916.502928-1-c.heiss@proxmox.com>
X-Mailer: git-send-email 2.43.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.005 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [unconfigured.sh]
Subject: [pve-devel] [PATCH installer] unconfigured: move terminal size
setting before starting debug shell
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 12 Mar 2024 11:59:52 -0000
Otherwise, when using the serial debug shell, the console size will be
0x0. This in turn breaks the TUI installer, as it cannot detect the size
properly.
It also adjust the size to the proper 80x24 instead of 80x25, as
advertised in the log message.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
unconfigured.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/unconfigured.sh b/unconfigured.sh
index cf7de83..b921fc2 100755
--- a/unconfigured.sh
+++ b/unconfigured.sh
@@ -194,6 +194,11 @@ busybox --install -s || true
setupcon || echo "setupcon failed, TUI rendering might be garbled - $?"
+if [ "$serial" -ne 0 ]; then
+ echo "Setting terminal size to 80x24 for serial install"
+ stty columns 80 rows 24
+fi
+
if [ $proxdebug -ne 0 ]; then
/sbin/agetty -o '-p -- \\u' --noclear tty9 &
printf "\nDropping in debug shell before starting installation\n"
@@ -215,11 +220,6 @@ setsid /sbin/agetty -a root --noclear tty3 &
/usr/bin/proxmox-low-level-installer dump-env
if [ $proxtui -ne 0 ]; then
- if [ "$serial" -ne 0 ]; then
- echo "Setting terminal size to 80x24 for serial install"
- stty columns 80 rows 25
- fi
-
echo "Starting the TUI installer"
/usr/bin/proxmox-tui-installer 2>/dev/tty2
else
--
2.43.1