From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B94FA979CA for ; Tue, 5 Mar 2024 16:08:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EE78CAEE4 for ; Tue, 5 Mar 2024 16:08:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 5 Mar 2024 16:08:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B625D487D0 for ; Tue, 5 Mar 2024 16:08:05 +0100 (CET) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Tue, 5 Mar 2024 16:07:54 +0100 Message-Id: <20240305150758.252669-13-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240305150758.252669-1-m.carrara@proxmox.com> References: <20240305150758.252669-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v4 pve-storage 12/16] cephconfig: remove leading whitespace on write to Ceph config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2024 15:08:09 -0000 Because continued lines (lines following lines that end with '\') preserve whitespace, this commit removes any leading whitespace that is added by our config writer. This is done in order to make continued lines look less "awkward" when manually changing values in 'ceph.conf' after the file has been modified by our tooling. Before this commit, continued lines would have to be added as follows: [some_section] some_key = Lorem ipsum dolor sit amet, consectetur \ adipiscing elit, sed do eiusmod tempor incididunt ut labore et \ dolore magna aliqua. Due to whitespace being preserved, continued lines cannot be on the same indentation level as `some_key`. Furthermore, the indentation level might lead some users to mistakenly believe that leading whitespace is ignored. Thus, this commit removes the leading whitespace that is added by our config writer. Signed-off-by: Max Carrara --- Changes v2 --> v3: * new Changes v3 --> v4: * rebased due to previous changes Note: This patch may be dropped if not desired. src/PVE/CephConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/CephConfig.pm b/src/PVE/CephConfig.pm index c84b78f..888be08 100644 --- a/src/PVE/CephConfig.pm +++ b/src/PVE/CephConfig.pm @@ -108,7 +108,7 @@ sub write_ceph_config { # escape comment literals $value =~ s/(#|;)/\\$1/g; - $out .= "\t $key = $value\n"; + $out .= "$key = $value\n"; } $out .= "\n"; -- 2.39.2