From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D2A58979E0 for ; Tue, 5 Mar 2024 16:08:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B520DAE4A for ; Tue, 5 Mar 2024 16:08:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 5 Mar 2024 16:08:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D20354881C for ; Tue, 5 Mar 2024 16:08:03 +0100 (CET) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Tue, 5 Mar 2024 16:07:42 +0100 Message-Id: <20240305150758.252669-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.400 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tools.pm, ceph.pm, proxmox.com, mon.pm, cephconfig.pm] Subject: [pve-devel] [PATCH v4 ceph master, ceph quincy-stable-8, pve-storage, pve-manager 0/16] Fix #4759: Configure Permissions for ceph-crash.service X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2024 15:08:35 -0000 Fix #4759: Configure Permissions for ceph-crash.service - Version 4 =================================================================== Notable changes since v3 ------------------------ * Both parser and writer for 'ceph.conf' now have unit tests which run during make targets like e.g. `make deb`, thanks to `dh_auto_test` * The parser for 'ceph.conf' now correctly un-escapes comment literals (found while developing unit tests) * The writer for 'ceph.conf' now correctly escapes comment literals (found while developing unit tests) * The helper script called in 'postinst' of pve-manager for updating 'ceph.crash' in 'ceph.conf' now correctly handles an existing key being referenced directly and removes it (thanks Friedrich!) * The aforementioned helper script has more verbose output, showing explicitly what's being done to the configuration * The 'postinst' hook now prints an empty line before and after it runs to make it a little more visible * The 'postinst' hook now also restarts 'ceph-crash.service' if the user hasn't disabled it (thanks Friedrich!) For a detailed list of changes, please see the comments in the individual patches. Older Versions -------------- v1: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061546.html v2: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061646.html v3: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061802.html Summary of Changes ------------------ ceph (master): Max Carrara (2): debian: add patch to fix ceph crash dir permissions in postinst hook patches: add patch that reorders clients used by ceph-crash ...ly-adjust-permissions-of-var-lib-cep.patch | 54 +++++++++++++++++++ ...h-crash-change-order-of-client-names.patch | 30 +++++++++++ patches/series | 2 + 3 files changed, 86 insertions(+) create mode 100644 patches/0016-debian-recursively-adjust-permissions-of-var-lib-cep.patch create mode 100644 patches/0017-ceph-crash-change-order-of-client-names.patch ceph (quincy-stable-8): Max Carrara (2): debian: add patch to fix ceph crash dir permissions in postinst hook patches: add patch that reorders clients used by ceph-crash ...ly-adjust-permissions-of-var-lib-cep.patch | 54 +++++++++++++++++++ ...h-crash-change-order-of-client-names.patch | 30 +++++++++++ patches/series | 2 + 3 files changed, 86 insertions(+) create mode 100644 patches/0025-debian-recursively-adjust-permissions-of-var-lib-cep.patch create mode 100644 patches/0026-ceph-crash-change-order-of-client-names.patch pve-storage: Max Carrara (9): cephconfig: align our parser more with Ceph's parser cephconfig: support line-continuations in parser cephconfig: allow writing arbitrary sections cephconfig: support escaped comment literals cephconfig: emit warning for lines that fail to parse cephconfig: change code style inside config writer cephconfig: change order of written sections cephconfig: remove leading whitespace on write to Ceph config test: add tests for 'ceph.conf' parser and writer src/Makefile | 1 + src/PVE/CephConfig.pm | 95 +++-- src/PVE/Makefile | 4 + src/PVE/test/Makefile | 9 + src/PVE/test/ceph_conf_parse_write_test.pl | 402 +++++++++++++++++++++ 5 files changed, 490 insertions(+), 21 deletions(-) create mode 100644 src/PVE/test/Makefile create mode 100755 src/PVE/test/ceph_conf_parse_write_test.pl pve-manager: Max Carrara (3): ceph: introduce '/etc/pve/ceph' fix #4759: ceph: configure ceph-crash.service and its key bin/make: gather helper scripts in separate variable PVE/API2/Ceph.pm | 5 ++ PVE/API2/Ceph/MON.pm | 8 +++ PVE/Ceph/Tools.pm | 47 ++++++++++++++- bin/Makefile | 6 +- bin/pve-init-ceph-crash | 129 ++++++++++++++++++++++++++++++++++++++++ debian/postinst | 26 ++++++++ 6 files changed, 218 insertions(+), 3 deletions(-) create mode 100755 bin/pve-init-ceph-crash -- 2.39.2