From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A4F2A95D33 for ; Wed, 28 Feb 2024 13:07:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85B7FAE59 for ; Wed, 28 Feb 2024 13:07:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 28 Feb 2024 13:07:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B593D47B68 for ; Wed, 28 Feb 2024 13:07:11 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 28 Feb 2024 13:07:08 +0100 Message-Id: <20240228120708.25017-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [aplinfo.pm] Subject: [pve-devel] [PATCH manager] appliance index: fix precedence in size check for log rotation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2024 12:07:12 -0000 In Perl, > takes precedence over ||, see perldoc perlop, so currently the check will trigger with any size. Fixes: 805cae93 ("appliance index: rotate update log if bigger than 256 KiB") Signed-off-by: Fiona Ebner --- PVE/APLInfo.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/APLInfo.pm b/PVE/APLInfo.pm index a4acf490..07542743 100644 --- a/PVE/APLInfo.pm +++ b/PVE/APLInfo.pm @@ -213,7 +213,7 @@ sub get_apl_sources { sub update { my ($proxy) = @_; - if (-s $logfile || 0 > 1024 * 256) { + if ((-s $logfile || 0) > 1024 * 256) { rename($logfile, "$logfile.0"); } my $logfd = IO::File->new (">>$logfile"); -- 2.39.2