From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 059779576D; Tue, 27 Feb 2024 14:23:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E1E021CEF3; Tue, 27 Feb 2024 14:23:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Tue, 27 Feb 2024 14:23:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EE00C4753E; Tue, 27 Feb 2024 14:23:24 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com Date: Tue, 27 Feb 2024 14:23:24 +0100 Message-Id: <20240227132324.948467-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH widget-toolkit] datetimefield: fix changing date to end of month from short months X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2024 13:23:26 -0000 When selecting a new date, we get a date object from the currently selected date before the change. If that month has less days than what was selected for the new month, `setDate` will wrap that to the following month since the old month is still selected there. For example: select any date in april (has 30 days) then select the 31th of january this will actually select the 1st of january since we first get setDate: 20xx-04-XX -> 20xx-04-31 (wrap) -> 20xx-05-01 setMonth: 20xx-05-01 -> 20xx-01-01 To fix this, use the additional parameters of setFullYear[0] to set all of them simultaneously 0: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/setFullYear Signed-off-by: Dominik Csapak --- src/form/DateTimeField.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/form/DateTimeField.js b/src/form/DateTimeField.js index 4bfa9bd..ea09f8a 100644 --- a/src/form/DateTimeField.js +++ b/src/form/DateTimeField.js @@ -24,9 +24,7 @@ Ext.define('Proxmox.DateTimeField', { return; } let datetime = new Date(this.get('datetime')); - datetime.setDate(date.getDate()); - datetime.setMonth(date.getMonth()); - datetime.setFullYear(date.getFullYear()); + datetime.setFullYear(date.getFullYear(), date.getMonth(), date.getDate()); this.set('datetime', datetime); }, }, -- 2.30.2