From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CB728956DF for ; Tue, 27 Feb 2024 10:33:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AA3551A581 for ; Tue, 27 Feb 2024 10:33:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 27 Feb 2024 10:33:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9BC9E4768A for ; Tue, 27 Feb 2024 10:33:55 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 27 Feb 2024 10:33:42 +0100 Message-ID: <20240227093350.234523-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer] proxinstall: fix empty error message when default hostname is not changed X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2024 09:33:57 -0000 Perl strikes again - while an empty string evaluates falsy in Perl, it is still defined and thus the //-operator cannot be used here. Fixes: 93892c0 ("proxinstall: avoid open-coding FQDN sanity check") Reported-by: Maximiliano Sandoval Signed-off-by: Christoph Heiss --- proxinstall | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index 351b240..d28aeaa 100755 --- a/proxinstall +++ b/proxinstall @@ -461,7 +461,8 @@ sub create_ipconf_view { my $err = $@; if ($err || $text =~ m/.example.invalid$/) { - Proxmox::UI::message($err // 'Hostname does not look like a valid fully qualified domain name'); + $err = 'Hostname does not look like a valid fully qualified domain name' if !$err; + Proxmox::UI::message($err); $hostentry->grab_focus(); return; } else { -- 2.43.0