From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D7047941EB for ; Wed, 21 Feb 2024 15:35:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B791719F24 for ; Wed, 21 Feb 2024 15:35:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Feb 2024 15:35:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C506A44548 for ; Wed, 21 Feb 2024 15:35:12 +0100 (CET) From: Filip Schauer To: pve-devel@lists.proxmox.com Date: Wed, 21 Feb 2024 15:33:11 +0100 Message-Id: <20240221143317.134090-1-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, cpuconfig.pm, tools.pm] Subject: [pve-devel] [PATCH-SERIES v8 qemu-server, common] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2024 14:35:13 -0000 This patch series prevents starting a 32-bit VM using a 64-bit OVMF BIOS and makes the default value for 'kvm' during CPU hotplug consistent with the rest of the code. This is a breaking change for VMs with a different CPU architecture running on an x86_64 host. Changes since v7: * Rename is_native to is_native_arch to be more explicit * Move get_default_cpu_type from Helpers to CPUConfig * Default to host architecture when no $arch is given to get_cpu_bitness * die with a message on hotplug of non x86_64 CPUs in print_cpu_device Changes since v6: * Skip the CPU bitness check if $forcecpu is set * Take custom CPU types into account * Add a helper for getting the default CPU type * Unify the default value for 'kvm' * Move is_native from PVE::QemuServer to PVE::Tools Changes since v5: * Refactor get_cpu_bitness to die instead of returning undef * Pass cputype instead of the entire vm config to get_cpu_bitness Changes since v4: * Remove parentheses around post-if in get_cpu_bitness Changes since v3: * Move the cputypes_32bit list from QemuServer.pm to CPUConfig.pm * Turn cputypes_32bit into a hash for lookup * Create a helper get_cpu_bitness function in CPUConfig.pm * Describe how the list of 32-bit CPU types was obtained common: Filip Schauer (1): tools: add is_native_arch to compare the CPU architecture src/PVE/Tools.pm | 6 ++++++ 1 file changed, 6 insertions(+) qemu-server: Filip Schauer (5): cpu config: Add helper to get the default CPU type Prevent starting a 32-bit VM using a 64-bit OVMF BIOS Move is_native from PVE::QemuServer to PVE::Tools Unify the default value for 'kvm' cpu config: die on hotplug of non x86_64 CPUs PVE/QemuServer.pm | 23 +++++++------ PVE/QemuServer/CPUConfig.pm | 64 ++++++++++++++++++++++++++++++++----- 2 files changed, 67 insertions(+), 20 deletions(-) -- 2.39.2