From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2AA2093402 for ; Mon, 19 Feb 2024 18:14:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 03DB133712 for ; Mon, 19 Feb 2024 18:14:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Feb 2024 18:14:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A910B43A55 for ; Mon, 19 Feb 2024 18:14:22 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Date: Mon, 19 Feb 2024 18:14:12 +0100 Message-Id: <20240219171412.1576651-5-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240219171412.1576651-1-t.lamprecht@proxmox.com> References: <20240219171412.1576651-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 2/2] ui: storage: enable download-url button with Sys.AccessNetwork capability X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2024 17:14:54 -0000 Now that the new Sys.AccessNetwork privilege got added to access-control and the storage download and manager query API endpoints, the UI should reflect that change and allow opening the dialogue to download an image from URL also for the users that are allowed to do so through the new privilege. Signed-off-by: Thomas Lamprecht --- www/manager6/storage/Browser.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js index 457816a6..c2ad01e9 100644 --- a/www/manager6/storage/Browser.js +++ b/www/manager6/storage/Browser.js @@ -51,7 +51,10 @@ Ext.define('PVE.storage.Browser', { let contents = res.content.split(','); let enableUpload = !!caps.storage['Datastore.AllocateTemplate']; - let enableDownloadUrl = enableUpload && !!(caps.nodes['Sys.Audit'] && caps.nodes['Sys.Modify']); + let enableDownloadUrl = enableUpload && ( + !!(caps.nodes['Sys.Audit'] && caps.nodes['Sys.Modify']) || // for backward compat + !!caps.nodes['Sys.AccessNetwork'] // new explicit priv for querying (local) networks + ); if (contents.includes('backup')) { me.items.push({ -- 2.39.2