From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0E62B9322E for ; Mon, 19 Feb 2024 12:12:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E37061E146 for ; Mon, 19 Feb 2024 12:11:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Feb 2024 12:11:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0F35B43894 for ; Mon, 19 Feb 2024 12:11:52 +0100 (CET) From: Filip Schauer To: pve-devel@lists.proxmox.com Date: Mon, 19 Feb 2024 12:11:39 +0100 Message-Id: <20240219111140.40722-2-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240219111140.40722-1-f.schauer@proxmox.com> References: <20240219111140.40722-1-f.schauer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.116 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH qemu-server 1/1] fix #1905: Allow moving unused disks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2024 11:12:23 -0000 Allow moving unused/detached disks to another storage. Signed-off-by: Filip Schauer --- PVE/API2/Qemu.pm | 3 --- PVE/QemuServer.pm | 5 +++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 69c5896..97216a3 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -4283,9 +4283,6 @@ __PACKAGE__->register_method({ } elsif ($storeid) { $rpcenv->check($authuser, "/storage/$storeid", ['Datastore.AllocateSpace']); - die "cannot move disk '$disk', only configured disks can be moved to another storage\n" - if $disk =~ m/^unused\d+$/; - $load_and_check_move->(); # early checks before forking/locking my $realcmd = sub { diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b45507a..4527276 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -8036,7 +8036,8 @@ sub clone_disk { my ($newvmid, $dst_drivename, $efisize) = $dest->@{qw(vmid drivename efisize)}; my ($storage, $format) = $dest->@{qw(storage format)}; - my $use_drive_mirror = $full && $running && $src_drivename && !$snapname; + my $unused = $src_drivename =~ /^unused/; + my $use_drive_mirror = $full && $running && $src_drivename && !$snapname && !$unused; if ($src_drivename && $dst_drivename && $src_drivename ne $dst_drivename) { die "cloning from/to EFI disk requires EFI disk\n" @@ -8142,7 +8143,7 @@ no_data_clone: my $disk = dclone($drive); delete $disk->{format}; $disk->{file} = $newvolid; - $disk->{size} = $size if defined($size); + $disk->{size} = $size if defined($size) && !$unused; return $disk; } -- 2.39.2