From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4FC91931DC for ; Mon, 19 Feb 2024 11:37:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 327371D4D2 for ; Mon, 19 Feb 2024 11:37:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Feb 2024 11:37:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2729A4380E for ; Mon, 19 Feb 2024 11:37:07 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Mon, 19 Feb 2024 11:37:03 +0100 Message-Id: <20240219103706.256332-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager v2] fix #5251: login: set autocomplete on password and user X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2024 10:37:38 -0000 By default they have 'autocomplete=off'. From [1]: > In most modern browsers, setting autocomplete to "off" will not > prevent a password manager from asking the user if they would like to > save username and password information, or from automatically filling > in those values in a site's login form. See the autocomplete > attribute and login fields [2]. [1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete [2] https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#the_autocomplete_attribute_and_login_fields Signed-off-by: Maximiliano Sandoval --- Differences from v1: - Learn how to send emails - Fix 'fix #5251' prefix in commit titles www/manager6/window/LoginWindow.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/window/LoginWindow.js b/www/manager6/window/LoginWindow.js index a79f5a2a..aaeca355 100644 --- a/www/manager6/window/LoginWindow.js +++ b/www/manager6/window/LoginWindow.js @@ -344,6 +344,7 @@ Ext.define('PVE.window.LoginWindow', { itemId: 'usernameField', reference: 'usernameField', stateId: 'login-username', + inputAttrTpl: 'autocomplete=username', bind: { visible: "{!openid}", disabled: "{openid}", @@ -355,6 +356,7 @@ Ext.define('PVE.window.LoginWindow', { fieldLabel: gettext('Password'), name: 'password', reference: 'passwordField', + inputAttrTpl: 'autocomplete=current-password', bind: { visible: "{!openid}", disabled: "{openid}", -- 2.39.2