From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 24B8091179 for ; Tue, 13 Feb 2024 16:14:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F3B8638329 for ; Tue, 13 Feb 2024 16:14:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 13 Feb 2024 16:14:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2C17F47CEB for ; Tue, 13 Feb 2024 16:14:14 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 13 Feb 2024 16:14:02 +0100 Message-ID: <20240213151405.1282639-6-c.heiss@proxmox.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240213151405.1282639-1-c.heiss@proxmox.com> References: <20240213151405.1282639-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer v2 5/6] sys: command: add option to not print process output to stdout X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2024 15:14:45 -0000 If $noprint is set, the output of the command won't be printed to stdout of the parent process. Fully backwards-compatible again, only takes effect if the new argument is actually specified. Signed-off-by: Christoph Heiss --- Changes since v1: * added parameter documentation Proxmox/Sys/Command.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Proxmox/Sys/Command.pm b/Proxmox/Sys/Command.pm index 36e99c1..d145483 100644 --- a/Proxmox/Sys/Command.pm +++ b/Proxmox/Sys/Command.pm @@ -85,8 +85,9 @@ sub syscmd { # to exit early and ignore the rest of the process output. # * $input - Stdin contents for the spawned subprocess # * $noout - Whether to append any process output to the return value +# * $noprint - Whether to print any process output to the parents stdout sub run_command { - my ($cmd, $func, $input, $noout) = @_; + my ($cmd, $func, $input, $noout, $noprint) = @_; my $cmdstr; if (!ref($cmd)) { @@ -178,7 +179,7 @@ sub run_command { } elsif ($h eq $error) { $ostream .= $buf if !($noout || $func); } - print $buf; + print $buf if !$noprint; STDOUT->flush(); log_info($buf); } -- 2.43.0