From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AC242947AB for ; Fri, 9 Feb 2024 15:15:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 830F23A7B4 for ; Fri, 9 Feb 2024 15:15:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 9 Feb 2024 15:15:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 94F2046880 for ; Fri, 9 Feb 2024 15:15:28 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 9 Feb 2024 15:15:03 +0100 Message-Id: <20240209141503.62402-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [restenvironment.pm] Subject: [pve-devel] [PATCH v2 common] REST environment: warn helpers: also log messages to syslog X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2024 14:15:29 -0000 for better visibility. When not in a task, warnings from these helpers are only logged to STDERR, which is particularly unhelpful in case of daemons. This is the main motivation behind this change. For tasks, warnings from these helpers are already more visible on the UI side, but when looking at the syslog, one can only see the warning count from the task right now, not the actual messages. This is another reason in favor of the change. Reported-by: Friedrich Weber Suggested-by: Thomas Lamprecht Signed-off-by: Fiona Ebner --- Changes in v2: * Go with the approach suggested by Thomas. src/PVE/RESTEnvironment.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm index 191c6eb..bfde7e6 100644 --- a/src/PVE/RESTEnvironment.pm +++ b/src/PVE/RESTEnvironment.pm @@ -723,6 +723,7 @@ sub log_warn { $rest_env->warn($message); } else { chomp($message); + syslog('warning', "%s", $message); print STDERR "WARN: $message\n"; } } @@ -732,6 +733,7 @@ sub warn { chomp($message); + syslog('warning', "%s", $message); print STDERR "WARN: $message\n"; $self->{warning_count}++; -- 2.39.2