From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DA626945CD for ; Fri, 9 Feb 2024 14:08:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A7FC639BC2 for ; Fri, 9 Feb 2024 14:08:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 9 Feb 2024 14:08:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C82FC46830 for ; Fri, 9 Feb 2024 14:08:24 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 9 Feb 2024 14:08:21 +0100 Message-Id: <20240209130821.51461-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240209130821.51461-1-f.ebner@proxmox.com> References: <20240209130821.51461-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 3/3] ui: user edit: prohibit editing keys option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2024 13:08:55 -0000 by turning the field into a displayfield. The TFA configuration window should be used to set second factors. It's still worth showing the field in case it's a legacy value. Editing a secret that was originally synced from LDAP is a use case where editing the field might've still made sense, but it's arguably better to do that on the LDAP side then and re-sync. Signed-off-by: Fiona Ebner --- www/manager6/dc/UserEdit.js | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/www/manager6/dc/UserEdit.js b/www/manager6/dc/UserEdit.js index ca701312..c9b32773 100644 --- a/www/manager6/dc/UserEdit.js +++ b/www/manager6/dc/UserEdit.js @@ -128,7 +128,7 @@ Ext.define('PVE.dc.UserEdit', { ], advancedItems: [ { - xtype: 'textfield', + xtype: 'displayfield', name: 'keys', fieldLabel: gettext('Key IDs'), }, @@ -161,18 +161,7 @@ Ext.define('PVE.dc.UserEdit', { success: function(response, options) { var data = response.result.data; me.setValues(data); - if (data.keys) { - if (data.keys === 'x' || - data.keys === 'x!oath' || - data.keys === 'x!u2f' || - data.keys === 'x!yubico') { - me.down('[name="keys"]').setDisabled(1); - } - if (data.keys === 'x') { - me.down('[name="keys"]').setHidden(true); - } - } else { - me.down('[name="keys"]').setDisabled(true); + if (!data.keys || data.keys === 'x') { me.down('[name="keys"]').setHidden(true); } }, -- 2.39.2