From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C42C2945CE for ; Fri, 9 Feb 2024 14:08:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A571A39C03 for ; Fri, 9 Feb 2024 14:08:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 9 Feb 2024 14:08:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B5AE946848 for ; Fri, 9 Feb 2024 14:08:24 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 9 Feb 2024 14:08:20 +0100 Message-Id: <20240209130821.51461-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240209130821.51461-1-f.ebner@proxmox.com> References: <20240209130821.51461-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 2/3] ui: user edit: hide key field except for legacy values X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2024 13:08:25 -0000 It should not be possible to set new legacy values via the UI, the TFA configuration window should be used to set second factors. Existing values are only interesting to show in case it's one of the legacy values 'x!' or a legacy secret e.g. synced from LDAP. In the latter case it's kept editable like it previously was. Signed-off-by: Fiona Ebner --- www/manager6/dc/UserEdit.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/www/manager6/dc/UserEdit.js b/www/manager6/dc/UserEdit.js index ad52edf0..ca701312 100644 --- a/www/manager6/dc/UserEdit.js +++ b/www/manager6/dc/UserEdit.js @@ -168,6 +168,12 @@ Ext.define('PVE.dc.UserEdit', { data.keys === 'x!yubico') { me.down('[name="keys"]').setDisabled(1); } + if (data.keys === 'x') { + me.down('[name="keys"]').setHidden(true); + } + } else { + me.down('[name="keys"]').setDisabled(true); + me.down('[name="keys"]').setHidden(true); } }, }); -- 2.39.2