From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 50B339427B for ; Fri, 9 Feb 2024 13:15:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3181F38B5B for ; Fri, 9 Feb 2024 13:14:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 9 Feb 2024 13:14:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 657DF4665E for ; Fri, 9 Feb 2024 13:14:30 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 9 Feb 2024 13:14:25 +0100 Message-Id: <20240209121427.39046-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240209121427.39046-1-f.ebner@proxmox.com> References: <20240209121427.39046-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qmpclient.pm] Subject: [pve-devel] [PATCH qemu-server 2/4] QMP client: remove unnecessary question mark from comment X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2024 12:15:01 -0000 There might've been a question back when it got first added in commit 9d689077 ("use long timeouts for snapshot monitor command"). But nowadays, the value is well-established. Changing it would affect quite a few operations, so that should not be done without good reason and is likely better done for the specific operation. Signed-off-by: Fiona Ebner --- PVE/QMPClient.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm index 0a35db74..42e54f01 100644 --- a/PVE/QMPClient.pm +++ b/PVE/QMPClient.pm @@ -132,7 +132,7 @@ sub cmd { $cmd->{execute} eq 'blockdev-snapshot-internal-sync' || $cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync' ) { - $timeout = 10*60; # 10 mins ? + $timeout = 10*60; # 10 mins } else { # NOTE: if you came here as user and want to change this, try using IO-Threads first # which move out quite some processing of the main thread, leaving more time for QMP -- 2.39.2