From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <c.heiss@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id D664993E10
for <pve-devel@lists.proxmox.com>; Wed, 7 Feb 2024 15:28:30 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id BDBC212033
for <pve-devel@lists.proxmox.com>; Wed, 7 Feb 2024 15:28:30 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Wed, 7 Feb 2024 15:28:29 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 24C4B44CBD
for <pve-devel@lists.proxmox.com>; Wed, 7 Feb 2024 15:28:28 +0100 (CET)
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Wed, 7 Feb 2024 15:28:11 +0100
Message-ID: <20240207142824.2613933-1-c.heiss@proxmox.com>
X-Mailer: git-send-email 2.43.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.003 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com, runenv.pm, bootdisk.rs, mod.rs, options.rs]
Subject: [pve-devel] [PATCH installer v2 0/3] expose zfs arc size setting
for all products
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2024 14:28:30 -0000
As suggested by Thomas, leaves the ZFS default if the user never touches
the setting in the installer (i.e. not writing a modprobe file).
See also the discussion in v1 [0].
[0] https://lists.proxmox.com/pipermail/pve-devel/2024-February/061659.html
Testing
-------
Tested the installation of PVE and PBS, with each once letting the arc
size setting untouched and once setting it to some specific value.
Afterwards, checked that for PVE the module parameter was always written
to /etc/modprobe.d/, for PBS that it was only written in case it was
set.
Previous revisions
------------------
v1: https://lists.proxmox.com/pipermail/pve-devel/2023-November/060898.html
Changes v1 -> v2:
* rebased on latest master
* add placeholder functionality for arc max size in TUI
* "emulate" placeholder functionality in GTK on best-effort basis
Christoph Heiss (3):
tui: NumericEditView: add optional placeholder value
tui: expose arc size setting for zfs bootdisks for all products
proxinstall: expose arc size setting for zfs bootdisks for all
products
Proxmox/Install/RunEnv.pm | 3 +-
proxinstall | 37 +++++++----
proxmox-installer-common/src/options.rs | 3 +-
proxmox-tui-installer/src/views/bootdisk.rs | 48 ++++++++------
proxmox-tui-installer/src/views/mod.rs | 69 +++++++++++++++++++--
5 files changed, 124 insertions(+), 36 deletions(-)
--
2.42.0