From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 33A5E93AC5 for ; Tue, 6 Feb 2024 14:15:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 10AB533FBB for ; Tue, 6 Feb 2024 14:15:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 6 Feb 2024 14:15:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1DBA2447E1 for ; Tue, 6 Feb 2024 14:15:01 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 6 Feb 2024 14:12:26 +0100 Message-ID: <20240206131441.781160-2-c.heiss@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, github.io, options.rs] URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [185.199.109.153, 185.199.108.153, 185.199.110.153, 185.199.111.153] Subject: [pve-devel] [PATCH installer] proxinstall, common: remove "off" as zfs checksum option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2024 13:15:02 -0000 See also the thread at [0] for the initial discussion/idea. Disabling checksums is considered an "extraordinarily bad idea" [1] (for pretty obvious reason) and nobody should really ever use it. Thus remove the option completely; just so that users cannot simply disable checksum "for performance reasons" without knowing about the implications of this. As pointed out by Thomas, it can still be set to "off" after the installation using the `zfs` tool, if really wanted. [0] https://lists.proxmox.com/pipermail/pve-devel/2023-December/061188.html [1] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/Checksums.html#disabling-checksums Signed-off-by: Christoph Heiss --- proxinstall | 2 +- proxmox-installer-common/src/options.rs | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/proxinstall b/proxinstall index d6d5acb..81dd368 100755 --- a/proxinstall +++ b/proxinstall @@ -1145,7 +1145,7 @@ my $create_raid_advanced_grid = sub { my $combo_checksum = Gtk3::ComboBoxText->new(); $combo_checksum->set_tooltip_text("zfs checksum algorithm for rpool dataset"); - my $csum_opts = ["on", "off", "fletcher4", "sha256"]; + my $csum_opts = ["on", "fletcher4", "sha256"]; foreach my $opt (@$csum_opts) { $combo_checksum->append($opt, $opt); } diff --git a/proxmox-installer-common/src/options.rs b/proxmox-installer-common/src/options.rs index 98cd907..1aa8f65 100644 --- a/proxmox-installer-common/src/options.rs +++ b/proxmox-installer-common/src/options.rs @@ -145,7 +145,6 @@ pub const ZFS_COMPRESS_OPTIONS: &[ZfsCompressOption] = { pub enum ZfsChecksumOption { #[default] On, - Off, Fletcher4, Sha256, } @@ -164,7 +163,7 @@ impl From<&ZfsChecksumOption> for String { pub const ZFS_CHECKSUM_OPTIONS: &[ZfsChecksumOption] = { use ZfsChecksumOption::*; - &[On, Off, Fletcher4, Sha256] + &[On, Fletcher4, Sha256] }; #[derive(Clone, Debug)] -- 2.43.0