From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1592593510 for ; Mon, 5 Feb 2024 13:29:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E2120166CA for ; Mon, 5 Feb 2024 13:28:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 5 Feb 2024 13:28:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9B20444342 for ; Mon, 5 Feb 2024 13:28:57 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 5 Feb 2024 13:28:53 +0100 Message-Id: <20240205122854.83495-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH common 1/2] REST environment: warn helpers: use warn instead of printing to stderr X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2024 12:29:29 -0000 Like this, __WARN__ handlers will still be called. In particular, daemons like pvestatd will set a __WARN__ handler and also log warnings to syslog. The intention behind introducing log_warn() was to make warnings more visible, not less, so fix the semantics to make sure switching from warn to log_warn() does not have this unintended side-effect. Reported-by: Friedrich Weber Signed-off-by: Fiona Ebner --- src/PVE/RESTEnvironment.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm index 191c6eb..41efb16 100644 --- a/src/PVE/RESTEnvironment.pm +++ b/src/PVE/RESTEnvironment.pm @@ -723,7 +723,7 @@ sub log_warn { $rest_env->warn($message); } else { chomp($message); - print STDERR "WARN: $message\n"; + warn "WARN: $message\n"; } } @@ -732,7 +732,7 @@ sub warn { chomp($message); - print STDERR "WARN: $message\n"; + warn "WARN: $message\n"; $self->{warning_count}++; } -- 2.39.2