From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C4B4991AC7 for ; Tue, 30 Jan 2024 19:41:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3993032556 for ; Tue, 30 Jan 2024 19:41:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 30 Jan 2024 19:40:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 49CA049374 for ; Tue, 30 Jan 2024 19:40:59 +0100 (CET) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Tue, 30 Jan 2024 19:40:35 +0100 Message-Id: <20240130184041.1125674-3-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240130184041.1125674-1-m.carrara@proxmox.com> References: <20240130184041.1125674-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH quincy-stable-8 ceph 2/8] debian: add patch to fix ceph crash dir permissions in postinst hook X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2024 18:41:31 -0000 Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*' to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'. This patch therefore also updates the permissions of '/var/lib/ceph/*/*'. Signed-off-by: Max Carrara --- ...rmissions-of-subdirectories-of-var-l.patch | 42 +++++++++++++++++++ patches/series | 1 + 2 files changed, 43 insertions(+) create mode 100644 patches/0024-debian-adjust-permissions-of-subdirectories-of-var-l.patch diff --git a/patches/0024-debian-adjust-permissions-of-subdirectories-of-var-l.patch b/patches/0024-debian-adjust-permissions-of-subdirectories-of-var-l.patch new file mode 100644 index 000000000..951a2a6ed --- /dev/null +++ b/patches/0024-debian-adjust-permissions-of-subdirectories-of-var-l.patch @@ -0,0 +1,42 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Max Carrara +Date: Thu, 11 Jan 2024 14:04:16 +0100 +Subject: [PATCH] debian: adjust permissions of subdirectories of /var/lib/ceph + +A rather recent PR made ceph-crash run as "ceph" user instead of +root [0]. However, because /var/lib/ceph/crash/posted belongs to root, +ceph-crash cannot actually post any crash logs now. + +This commit fixes this by also updating the permissions of +/var/lib/ceph/*/* - the subdirectories of the directories in +/var/lib/ceph. + +[0]: https://github.com/ceph/ceph/pull/48713 + +Signed-off-by: Max Carrara +--- + debian/ceph-base.postinst | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/debian/ceph-base.postinst b/debian/ceph-base.postinst +index 75eeb59c624..7ca0b9b6c43 100644 +--- a/debian/ceph-base.postinst ++++ b/debian/ceph-base.postinst +@@ -40,6 +40,14 @@ case "$1" in + chown $SERVER_USER:$SERVER_GROUP $DIR + fi + done ++ ++ # also adjust file and directory permissons for subdirectories ++ for SUBDIR in /var/lib/ceph/*/* ; do ++ if ! dpkg-statoverride --list $SUBDIR >/dev/null ++ then ++ chown $SERVER_USER:$SERVER_GROUP $SUBDIR ++ fi ++ done + ;; + abort-upgrade|abort-remove|abort-deconfigure) + : +-- +2.39.2 + diff --git a/patches/series b/patches/series index 73f66396c..f549e0837 100644 --- a/patches/series +++ b/patches/series @@ -15,3 +15,4 @@ 0020-fix-4759-run-ceph-crash-daemon-with-www-data-group-f.patch 0021-debian-rules-fix-buildtype.patch 0022-rocksb-inherit-parent-cmake-cxx-flags.patch +0024-debian-adjust-permissions-of-subdirectories-of-var-l.patch -- 2.39.2