From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0CD0B91871 for ; Tue, 30 Jan 2024 11:28:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E0D2D30147 for ; Tue, 30 Jan 2024 11:28:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 30 Jan 2024 11:28:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BB72C45699 for ; Tue, 30 Jan 2024 11:28:34 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 30 Jan 2024 11:28:31 +0100 Message-Id: <20240130102831.19846-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 storage] plugin schema: improve description of 'shared' property X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2024 10:28:36 -0000 It's not clear to users what this property does otherwise. Latest report from the community forum: https://forum.proxmox.com/threads/134393 Signed-off-by: Fiona Ebner --- Changes in v2: * improve wording based on Fabian's suggestions, thanks! @Fabian: I didn't want to drop the "single" and I felt like the "on all nodes that can access it" might leave some users thinking when there's nothing to think about: the storage has to be accessible from all nodes (or all configured 'nodes'). "It will not automatically make a local storage shared" also didn't feel super helpful while we're still trying to explain what "shared" means. I'll send a patch for pve-docs once the wording is accepted. src/PVE/Storage/Plugin.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index fbbf491..e086de9 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -170,7 +170,10 @@ my $defaultData = { default => "Unlimited for users with Datastore.Allocate privilege, 5 for other users", }, shared => { - description => "Mark storage as shared.", + description => "Indicate that this is a single storage with the same contents on all " + ."nodes (or all listed in the 'nodes' option). It will not make the contents of a " + ."local storage automatically accessible to other nodes, it just marks an already " + ."shared storage as such!", type => 'boolean', optional => 1, }, -- 2.39.2