From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C08CF91509 for ; Mon, 29 Jan 2024 10:47:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A07BF13772 for ; Mon, 29 Jan 2024 10:47:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 29 Jan 2024 10:47:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EBE97458D7 for ; Mon, 29 Jan 2024 10:47:43 +0100 (CET) From: Alexander Zeidler To: pve-devel@lists.proxmox.com Date: Mon, 29 Jan 2024 10:47:05 +0100 Message-Id: <20240129094705.18951-1-a.zeidler@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pvesubscription.pm, proxmox.com] Subject: [pve-devel] [PATCH v2 manager] pvesubscription: add missing return statement X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2024 09:47:45 -0000 to avoid a failing null check and its error message. This confused users since the activation was successful anyway. Signed-off-by: Alexander Zeidler --- v2: * use "return" instead of "return undef" * add commit message v1: https://lists.proxmox.com/pipermail/pve-devel/2024-January/061280.html PVE/CLI/pvesubscription.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/CLI/pvesubscription.pm b/PVE/CLI/pvesubscription.pm index efd4ada4..51f5b71e 100755 --- a/PVE/CLI/pvesubscription.pm +++ b/PVE/CLI/pvesubscription.pm @@ -48,6 +48,8 @@ __PACKAGE__->register_method({ PVE::API2::Subscription::check_key($info->{key}, PVE::API2::Subscription::get_sockets()); PVE::API2::Subscription::write_etc_subscription($info); + + return; }}); our $cmddef = { -- 2.39.2