From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BDEE591158 for ; Fri, 26 Jan 2024 18:18:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A7D5638F2E for ; Fri, 26 Jan 2024 18:18:08 +0100 (CET) Received: from mail-pf1-x464.google.com (mail-pf1-x464.google.com [IPv6:2607:f8b0:4864:20::464]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 26 Jan 2024 18:18:08 +0100 (CET) Received: by mail-pf1-x464.google.com with SMTP id d2e1a72fcca58-6dbb003be79so1637657b3a.0 for ; Fri, 26 Jan 2024 09:18:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=primordial.ca; s=google; t=1706289480; x=1706894280; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KxT8x+skKED3XrUf30hZyCsE2+v2LkYEUhv7I4CVvek=; b=Eed58Z1MrkVu0FrHaWPYBaH3DREra1va3vBNxFoQZzT6XZM+Thlsl2DvlZY7A7XKeN bMBICvnKG3Lk0/XS9AmFXKPCnK3t6WEFqQTF6aTPSHCYVnKYiFIxPzniwLNlyxS+zJxQ H4iev35qdOWmsszpHxDq+HqMHV2uCrrcjWOeg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706289480; x=1706894280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KxT8x+skKED3XrUf30hZyCsE2+v2LkYEUhv7I4CVvek=; b=PScke8QF1OR7Lg1baubOpjpb1UDl0mzYeLgr6ERmKGm7U5DB8DOn3CRTnEqO154LX5 Pe60zzdvvbjviYiq1k/wV6gA9y2Ukg7JPHBV6E5xDnvrsxEnrB/AQJ4YQnIv96kArHZS 2fb0AMH2LwNWbxjWA2I+eXr5jPE04ipSIQPgWiQa5vmHN25IId1CHi/e/JqgEWDqvkSi nPFDOSgSFOfQyqfZSgRgBSufe08LTKew4977NMg7Mlh9FPBMqBX085zTPjHm0fBVqSYy hbSJB68/E0h8wPKT1vd8ryY8VlUHr1WachebuHdyP358+OXKHSlgnKQLZI1NaQ5AH39J Fz5A== X-Gm-Message-State: AOJu0YxJ/P7K6yyr4covuFP8o10yDlTjYac7HMzNVS+CZxIk8jVrJLdS 2i/E1jRXryY/ispukx4xc4TKy54gdUzj0ZjylGi2Xbc4r/TZ//L1Tz4rM9zRWg+knr9e9vP2z7e D4wGAqMYP21qGndLSp+X+KVBh3rzofM7HdcmDO6GRz/LRiQDb X-Google-Smtp-Source: AGHT+IEAFPUhtLB+mVAr3YpFBueEI684WTZYxCP3E9NVLQL6HEDSugfomdpV3ga87NcVzmJD3ZuXW37OLEr/ X-Received: by 2002:a05:6a21:33aa:b0:19c:2c3e:eab1 with SMTP id yy42-20020a056a2133aa00b0019c2c3eeab1mr1668756pzb.1.1706289480171; Fri, 26 Jan 2024 09:18:00 -0800 (PST) Received: from prime.int.primordial.ca (tunnel228220-pt.tunnel.tserv21.tor1.ipv6.he.net. [2001:470:1c:aaf::2]) by smtp-relay.gmail.com with ESMTPS id y24-20020a634958000000b005cf94886bcbsm59375pgk.31.2024.01.26.09.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 09:18:00 -0800 (PST) X-Relaying-Domain: primordial.ca Received: from dark.int.primordial.ca (dark.int.primordial.ca [192.168.1.7]) by prime.int.primordial.ca (8.17.2/8.17.1) with ESMTP id 40QHHuMD715190; Fri, 26 Jan 2024 12:17:58 -0500 From: Jillian Morgan To: pve-devel@lists.proxmox.com Date: Fri, 26 Jan 2024 12:17:29 -0500 Message-ID: <20240126171741.2251760-2-jillian.morgan@primordial.ca> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240126171741.2251760-1-jillian.morgan@primordial.ca> References: <20240126171741.2251760-1-jillian.morgan@primordial.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_MISSING 0.1 Missing DMARC policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - X-Mailman-Approved-At: Mon, 29 Jan 2024 12:38:14 +0100 Subject: [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 1/2] X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2024 17:18:08 -0000 Allow bridges to have any valid interface name Repo: proxmox-widget-toolkit Allow the web UI to accept bridge interfaces with any valid interface name, rather than being limited to the arbitrary "vmbr" prefix. Signed-off-by: Jillian Morgan --- proxmox-widget-toolkit/src/Toolkit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Toolkit.js b/src/Toolkit.js index 6fd73f5..3a03f55 100644 --- a/src/Toolkit.js +++ b/src/Toolkit.js @@ -76,7 +76,7 @@ Ext.apply(Ext.form.field.VTypes, { MacPrefixText: gettext('Example') + ': 02:8f - ' + gettext('only unicast addresses are allowed'), BridgeName: function(v) { - return (/^vmbr\d{1,4}$/).test(v); + return (/^[a-z][a-z0-9_]{1,20}$/).test(v); }, VlanName: function(v) { if (Proxmox.Utils.VlanInterface_match.test(v)) {